450 allow intents to target app instances #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriswest
requested review from
mattjamieson,
thorsent,
rikoe,
donbasuno,
ggeorgievx and
a team
kriswest
added
channels feeds & transactions
…ications and errors on non-existent target instances
11 tasks
mattjamieson
requested changes
Dec 21, 2021
Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
mattjamieson
approved these changes
Jan 6, 2022
rikoe
approved these changes
Jan 27, 2022
10 tasks
ggeorgievx
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #450
Adds an optional
instanceIdfield toAppMetadata, allowing it to represent specific instances of applications.Also updates
open()to returnAppMetadata(identifying the instance opened).raiseIntent()already returns details of the app resolving an intent, however, this should now always be anAppMetadata, with the optionalAppMetadata.instanceIdfield set, to represent the app instance that received the intent (and may have been started to do so).