Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to existing docs. #62

Merged
merged 3 commits into from
Mar 22, 2019
Merged

Conversation

RichLinnell
Copy link
Contributor

No description provided.

@finos-admin
Copy link
Member

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@RichLinnell). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

@finos-admin
Copy link
Member

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@RichLinnell). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

@finos-admin
Copy link
Member

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@RichLinnell). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

@RichLinnell RichLinnell changed the title Minor changes to App Directory docs Minor changes to existing docs. Mar 15, 2019
Copy link
Contributor

@nkolba nkolba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. @rikoe what do you think of getting these proofreads into 1.0?

@rikoe
Copy link
Contributor

rikoe commented Mar 22, 2019

@nkolba @RichLinnell we should - that means the same changes should be made to the 1.0 snapshot docs in https://github.com/FDC3/FDC3/tree/master/website/versioned_docs/version-1.0.

@finos-admin
Copy link
Member

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@RichLinnell). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

@rikoe rikoe merged commit 493ed46 into finos:master Mar 22, 2019
@rikoe rikoe added this to the 1.0 milestone Mar 25, 2019
kriswest added a commit that referenced this pull request May 17, 2023
* convert svg to png

* remove svg

* Make sure URL ends with trailing / for image path resolution

Co-authored-by: Kris West <kris@cosaic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants