506 deprecate name field in API calls

[kriswest]

resolves #506

Removes the TargetApp union type (string | Appmetadata) which splits the signatures for open, raiseIntent and raiseIntentForContext into two versions, then deprecates the version based on on the name field. Also makes name optional, but appId required and splits AppMetadata into AppIdentifier and AppMetadata which extends it - this helps to clarify what the requirements are for function calls, vs. the return types (thanks for the suggestion @thorsent).

Also:

• tidies up the deprecated DesktopAgent functions in docs and sources
• applies markdown linting so some of the docs files

As discussed at #683

[netlify]

✅ Deploy Preview for lambent-kulfi-cf51a7 ready!

Name	Link
🔨 Latest commit	c61b919
🔍 Latest deploy log	https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/62878b3fbd0e2100092801a7
😎 Deploy Preview	https://deploy-preview-722--lambent-kulfi-cf51a7.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[thorsent]

Nice

[kriswest]

Thanks @mattjamieson @greyseer256, suggestions applied

[bingenito]

Shouldn't these overloads be wrapping the string as an AppIdentifier internally? Otherwise why is there a check and if-else?

[kriswest]

The typeguard and check were needed as typescript will allow us to declare the different types for the function overload, but in the implementation, javascript won't (the second declaration will just overwrite the first, which typescript knows and will spit out as an error).

Hence, this looks odd in this utility file, but works correctly and looks correct in the types/docs (and provides the overload for use in other languages that actually care about the types of function arguments, which JS does not). Hence, JS implementations will still use a single function to implement both signatures and will have to do some similar type checking internally.

Makes a bit more sense when you see it in VS code and it highlights that one of the calls fdc3.open is the deprecated form:

I can't wrap the name as an AppIdentifier internally as we're missing the required appId.

[nkolba]

LGTM