Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Data and Intents consolidated update PR #724

Merged
merged 131 commits into from
May 27, 2022

Conversation

mistryvinay
Copy link
Contributor

@mistryvinay mistryvinay commented May 18, 2022

Consolidated PR for Context Data & Intents (CD&I) updates (each of which is raised as a separate PR into this branch for review by CD&I discussion group members, maintainers and editors).

resolves #574
resolves #587
resolves #588
resolves #589
resolves #590
resolves #600
resolves #624
resolves #645
resolves #646
resolves #651
resolves #652
resolves #654
resolves #681

pauldyson and others added 30 commits March 8, 2022 11:51
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
mistryvinay and others added 17 commits May 25, 2022 14:25
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Copy link
Contributor Author

@mistryvinay mistryvinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR with suggested feedback and commits.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/context/ref/ChatInitSettings.md Outdated Show resolved Hide resolved
docs/context/spec.md Outdated Show resolved Hide resolved
docs/context/spec.md Outdated Show resolved Hide resolved
docs/intents/ref/StartChat.md Outdated Show resolved Hide resolved
@kriswest kriswest requested a review from a team May 26, 2022 08:56
Co-authored-by: Hugh Troeger <htroeger@factset.com>
@kriswest kriswest modified the milestones: 2.0-candidates, 2.0 May 27, 2022
@kriswest kriswest merged commit 1a3a15d into master May 27, 2022
@kriswest kriswest deleted the context-data-and-intents-consolidated-update-branch branch May 27, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment