Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating AppD name field and promoting title to required #928

Merged
merged 2 commits into from
May 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* Updated definition of the `Instrument` context type to include optional market identifiers ([#819](https://github.com/finos/FDC3/pull/819))

### Deprecated
* Deprecated the `name` field in AppD records, to match deprecation of API signatures and metadata objects using `name` (see ([#722](https://github.com/finos/FDC3/pull/722))
)) in 2.0 ([#928])(https://github.com/finos/FDC3/pull/928))

### Fixed

Expand Down
27 changes: 13 additions & 14 deletions src/app-directory/specification/appd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,20 @@ components:
description: >
The unique application identifier located within a specific
application directory instance.
title:
type: string
description: >-
Title for the application, typically used in a launcher UI.
type:
$ref: '#/components/schemas/Type'
details:
$ref: '#/components/schemas/LaunchDetails'
name:
type: string
description: >
Deprecated in favour of using `appId` to identify apps and `title`
for their display names.

The name of the application.

The name should be unique within an FDC3 App Directory instance. The
Expand All @@ -310,21 +321,13 @@ components:

The same appName could occur in other directories. We are not
currently specifying app name conventions in the document.
type:
$ref: '#/components/schemas/Type'
details:
$ref: '#/components/schemas/LaunchDetails'
deprecated: true
version:
type: string
description: >-
Version of the application. This allows multiple app versions to be
defined using the same app name. This can be a triplet but can also
include things like 1.2.5 (BETA)
title:
type: string
description: >-
Optional title for the application, if missing use appName,
typically used in a launcher UI.
tooltip:
type: string
description: Optional tooltip description e.g. for a launcher
Expand Down Expand Up @@ -436,7 +439,7 @@ components:
discussed elsewhere in the FDC3 App Directory spec.
required:
- appId
- name
- title
- type
- details
allOf:
Expand Down Expand Up @@ -872,7 +875,6 @@ components:
FDC3WorkbenchAppDefinition:
value:
appId: fdc3-workbench
name: fdc3-workbench
title: FDC3 Workbench
description: Development and test tool for FDC3 desktop agents and apps
categories: [developer tools, training]
Expand Down Expand Up @@ -951,7 +953,6 @@ components:
MyAppDefinition:
value:
appId: my-application
name: my-application
title: My Application
description: An example application that uses FDC3 and fully describes itself in an AppD record.
categories: [market data, research, news]
Expand Down Expand Up @@ -1066,7 +1067,6 @@ components:
value:
applications: # you can't $ref inside a $ref so example is repeated here for search response
- appId: my-application
name: my-application
title: My Application
description: An example application that uses FDC3 and fully describes itself in an AppD record.
categories: [market data, research, news]
Expand Down Expand Up @@ -1177,7 +1177,6 @@ components:
title: Mon application,
description: Un exemple d'application qui utilise FDC3 et se décrit entièrement dans un enregistrement AppD.
- appId: fdc3-workbench
name: fdc3-workbench
title: FDC3 Workbench
description: Development and test tool for FDC3 desktop agents and apps
categories: [developer tools, training]
Expand Down
27 changes: 13 additions & 14 deletions website/static/schemas/next/app-directory.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,20 @@ components:
description: >
The unique application identifier located within a specific
application directory instance.
title:
type: string
description: >-
Title for the application, typically used in a launcher UI.
type:
$ref: '#/components/schemas/Type'
details:
$ref: '#/components/schemas/LaunchDetails'
name:
type: string
description: >
Deprecated in favour of using `appId` to identify apps and `title`
for their display names.

The name of the application.

The name should be unique within an FDC3 App Directory instance. The
Expand All @@ -310,21 +321,13 @@ components:

The same appName could occur in other directories. We are not
currently specifying app name conventions in the document.
type:
$ref: '#/components/schemas/Type'
details:
$ref: '#/components/schemas/LaunchDetails'
deprecated: true
version:
type: string
description: >-
Version of the application. This allows multiple app versions to be
defined using the same app name. This can be a triplet but can also
include things like 1.2.5 (BETA)
title:
type: string
description: >-
Optional title for the application, if missing use appName,
typically used in a launcher UI.
tooltip:
type: string
description: Optional tooltip description e.g. for a launcher
Expand Down Expand Up @@ -436,7 +439,7 @@ components:
discussed elsewhere in the FDC3 App Directory spec.
required:
- appId
- name
- title
- type
- details
allOf:
Expand Down Expand Up @@ -872,7 +875,6 @@ components:
FDC3WorkbenchAppDefinition:
value:
appId: fdc3-workbench
name: fdc3-workbench
title: FDC3 Workbench
description: Development and test tool for FDC3 desktop agents and apps
categories: [developer tools, training]
Expand Down Expand Up @@ -951,7 +953,6 @@ components:
MyAppDefinition:
value:
appId: my-application
name: my-application
title: My Application
description: An example application that uses FDC3 and fully describes itself in an AppD record.
categories: [market data, research, news]
Expand Down Expand Up @@ -1066,7 +1067,6 @@ components:
value:
applications: # you can't $ref inside a $ref so example is repeated here for search response
- appId: my-application
name: my-application
title: My Application
description: An example application that uses FDC3 and fully describes itself in an AppD record.
categories: [market data, research, news]
Expand Down Expand Up @@ -1177,7 +1177,6 @@ components:
title: Mon application,
description: Un exemple d'application qui utilise FDC3 et se décrit entièrement dans un enregistrement AppD.
- appId: fdc3-workbench
name: fdc3-workbench
title: FDC3 Workbench
description: Development and test tool for FDC3 desktop agents and apps
categories: [developer tools, training]
Expand Down