Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata generation support #280

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

willosborne
Copy link
Member

@willosborne willosborne commented Jun 11, 2024

Adds CLI support to back up changes to spec from #183 .
If metadata is defined it will recursively attempt to instantiate the objects set within. It will resolve refs too, but only on top-level objects.

i.e. you can have (approx, missed some detail out)

"metadata": [
   {
      "$ref": "xyz"
   }
]

but not

"metadata": [
   {
     property: {
       "$ref": "xyz"
     }
   }
]

Note that this also removes support for arbitrary additional top level properties, since this is what metadata replaces.

Copy link

linux-foundation-easycla bot commented Jun 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@willosborne willosborne merged commit b2f0fef into finos:main Jun 13, 2024
3 checks passed
@willosborne willosborne deleted the metadata-generation branch June 13, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants