generated from finos-labs/project-blueprint
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation feature for patterns only #326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willosborne
requested review from
aidanm3341,
lbulanti-ms,
grahampacker-ms,
jpgough-ms,
rocketstack-matt and
a team
as code owners
August 2, 2024 15:29
This is a good first cut, but I think we can improve upon this later - e.g. running with -v shows loads of 'strict mode' errors that could be useful here:
|
Catch errors in compile() to detect schema issues Tweaks to validate temp Fix bug in merging of results Undo test changes made to api-gateway.json Clean up the pattern-only logic api-gateway.json fix
aidanm3341
approved these changes
Aug 2, 2024
willosborne
force-pushed
the
pattern-only-validation
branch
from
August 2, 2024 15:48
636a74c
to
093919c
Compare
lbulanti-ms
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple validation mode that checks the provided pattern is valid JSON Schema; this isn't perfect but it gives us some guarantees.
Addresses issue #73 and #317