Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Interfaces for WIP Domain Example #330

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add new Interfaces for WIP Domain Example #330

merged 1 commit into from
Aug 9, 2024

Conversation

jpgough-ms
Copy link
Member

No description provided.

@jpgough-ms jpgough-ms requested a review from a team as a code owner August 8, 2024 14:21
@jpgough-ms jpgough-ms changed the title Fixes #328 Add new Interfaces for WIP Domain Example Aug 8, 2024
willosborne
willosborne approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@willosborne willosborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

  • image name should contain the URL for the registry. We could probably put a regex on this, but probably no need for now.
  • we now have port and host-port - this is fine, though

@jpgough-ms jpgough-ms merged commit 812dd32 into finos:main Aug 9, 2024
3 checks passed
@jpgough-ms jpgough-ms deleted the new-interfaces branch September 6, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willosborne willosborne willosborne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpgough-ms @willosborne