Fixes #333 Apply feedback from Matt #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
We should add a reference to the control.json into the calm.json the same way core.json is referenced otherwise the one-node-wonder doesn't know what a control-requirement is because the schema reference is to calm which currently knows nothing about controls.
There was a problem hiding this comment.
That's interesting, is this something we've broken with interface.json!
Co-authored-by: Matthew Bain <66839492+rocketstack-matt@users.noreply.github.com>
Co-authored-by: Matthew Bain <66839492+rocketstack-matt@users.noreply.github.com>
Update to match evidence schema
willosborne
reviewed
Aug 15, 2024
| @@ -1,28 +1,26 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/finos/architecture-as-code/main/calm/draft/2024-08/meta/calm.json", | |||
| "id": "one-node-wonder.json", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.