(#313) use consistent argument names #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanm3341
requested review from
lbulanti-ms,
willosborne,
grahampacker-ms,
jpgough-ms,
rocketstack-matt and
Thels
as code owners
cli/src/index.ts
Outdated
| @@ -55,7 +54,7 @@ program | |||
| .description('Validate that an instantiation conforms to a given CALM pattern.') | |||
| .requiredOption(PATTERN_OPTION, 'Path to the pattern file to use. May be a file path or a URL.') | |||
| .option(INSTANTIATION_OPTION, 'Path to the pattern instantiation file to use. May be a file path or a URL.') | |||
| .option(META_SCHEMA_OPTION, 'The location of the directory of the meta schemas to be loaded', CALM_META_SCHEMA_DIRECTORY) | |||
| .option(SCHEMAS_OPTION, 'The location of the directory of the meta schemas to be loaded', CALM_META_SCHEMA_DIRECTORY) | |||
There was a problem hiding this comment.
If we're making the param name the same, shouldn't we do the same with the description?
willosborne
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.