Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucía Cortés CapacityUnitEnum 6x #3198

Conversation

regnosys-prod-user
Copy link
Collaborator

No description provided.

Included Joule Value in CapacityUnitEnum
Copy link

linux-foundation-easycla bot commented Oct 25, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for finos-cdm ready!

Name Link
🔨 Latest commit 616bf08
🔍 Latest deploy log https://app.netlify.com/sites/finos-cdm/deploys/6733446eeb00b40008acd471
😎 Deploy Preview https://deploy-preview-3198--finos-cdm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LuciaCortesTH
Copy link
Contributor

LuciaCortesTH commented Oct 25, 2024

Issue: #3196
Release Notes
RN_CapacityUnitEnum.md

manel-martos
manel-martos previously approved these changes Nov 8, 2024
Copy link
Contributor

@manel-martos manel-martos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted at Nov 5th FINOS CDM Contribution Review

@JayasriR
Copy link
Contributor

@LuciaCortesTH Can you please add release notes for this. thanks

@LuciaCortesTH
Copy link
Contributor

LuciaCortesTH commented Nov 12, 2024 via email

@PayalKhanna
Copy link
Contributor

PayalKhanna commented Nov 12, 2024

@LuciaCortesTH The link on your comment doesn't show any RN
can you attach a .md file on the PR please or paste the RN details as comment
Thanks

@LuciaCortesTH
Copy link
Contributor

LuciaCortesTH commented Nov 12, 2024

@PayalKhanna Hello Payal, I replied via email, but the RN didn’t upload in the comment—sorry about that. Here they are (they’re the same for both capacity unit enum PR's). I’ve also added the RN in the PR comments alongside the issue link, not just in the original issue. Thank you!
RN_CapacityUnitEnum.md

PayalKhanna and others added 2 commits November 12, 2024 11:59
…d8032527345d0bc9560-CapacityUnitEnum

# Conflicts:
#	RELEASE.md
@hugohills-regnosys hugohills-regnosys merged commit 7ab3505 into finos:master Nov 12, 2024
7 checks passed
@hugohills-regnosys hugohills-regnosys deleted the lcortes_auth0_65c35d8032527345d0bc9560-CapacityUnitEnum branch November 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants