Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add price reference mapping for SettlementPayout.priceSchedule #3250

Merged

Conversation

hugohills-regnosys
Copy link
Contributor

No description provided.

@hugohills-regnosys hugohills-regnosys requested a review from a team as a code owner November 12, 2024 18:00
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for finos-cdm ready!

Name Link
🔨 Latest commit 5622982
🔍 Latest deploy log https://app.netlify.com/sites/finos-cdm/deploys/673f10d50f299b0008975bf4
😎 Deploy Preview https://deploy-preview-3250--finos-cdm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@lolabeis lolabeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok. I recommend that you also update the repo-and-bond / bon execution sample, which also uses a settlement payout.

lolabeis
lolabeis previously approved these changes Nov 21, 2024
Copy link
Contributor

@lolabeis lolabeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at the CDM Derivatives Products and Business Events Working Group - November 20th, 2024 and reviewed by maintainers for technical quality.

Please submit release notes for final approval.

@hugohills-regnosys hugohills-regnosys merged commit 64936f0 into finos:master Nov 21, 2024
7 checks passed
@hugohills-regnosys hugohills-regnosys deleted the fixed-price-ref-mapping branch November 21, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants