Fix AddContextListener to be async #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingenito
force-pushed
the
channel-async-fix
branch
from
e91c778 to
320b0eb
Compare
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 35 35
Lines 295 295
=======================================
Hits 261 261
Misses 34 34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
psmulovics
approved these changes
Mar 1, 2023
|
I cannot think of any other looking at the API surface; but any other API that needs to be async? |
They theoretically should have been done in the FDC3 v2 changes but I missed this one. It was discovered while doing the example app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.