Merge pull request #496 from finos/fix/report-on-coverage-only

Report on coverage only and block CI on tests failure #495
finos · Mar 22, 2024 · f1be6bf · f1be6bf
2 parents c17ca39 + 105b8c4
commit f1be6bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -43,7 +43,7 @@ jobs:
     - name: Test
       id: test
       run: |
-        npm run test-coverage-ci || echo "Silently ignoring coverage threshold limit..."
+        npm run test-coverage-ci
 
     - name: Upload test coverage report
       uses: codecov/codecov-action@v4.1.0

diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
     "server-test": "mocha --exit",
     "test": "mocha --exit",
     "test-coverage": "nyc npm run test",
-    "test-coverage-ci": "nyc --reporter=lcovonly --reporter=text --check-coverage npm run test",
+    "test-coverage-ci": "nyc --reporter=lcovonly --reporter=text npm run test",
     "prepare": "node ./scripts/prepare.js",
     "lint": "eslint --fix . --ext .js,.jsx",
     "gen-schema-doc": "node ./scripts/doc-schema.js"