Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review allowed licenses for dependencies introduced to the codebase 🔍 #518

Closed
3 tasks done
JamieSlome opened this issue Apr 8, 2024 · 4 comments
Closed
3 tasks done
Assignees
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed question Further information is requested

Comments

@JamieSlome
Copy link
Member

JamieSlome commented Apr 8, 2024

@maoo - during our community call today, we discussed the existing caniuse-lite CC-BY 4.0 CI warning that is blocking #482.

To practice sensible caution, we should review the existing allow-licenses provided to the Dependency Review GitHub Action.

Tasks

Preview Give feedback

@coopernetes @abinash2512 - thank you for your contribution to the conversation today around license compliance ❤️ Extremely valuable insight.

@JamieSlome JamieSlome added help wanted Extra attention is needed question Further information is requested dependencies Pull requests that update a dependency file labels Apr 8, 2024
@maoo
Copy link
Member

maoo commented Apr 8, 2024

Review existing licenses of dependencies permissible to introduce to the codebase - Done, all good, nothing to remove, see https://community.finos.org/docs/governance/software-projects/license-categories/

Re Add any licenses that are missing from the GitHub Action configuration , I would not add licenses that are not used; this will allow to use the dependency-review configuration as a curated list of licenses currently adopted in the project; worth noticing that - when we get to 2.0 - we'll have different configurations for different components.

WDYT?

@JamieSlome
Copy link
Member Author

@maoo - makes sense; I think? 🤔

One more thing I would like to check is do we want to add any items to a deny-list for licenses?

@maoo
Copy link
Member

maoo commented Apr 9, 2024

@maoo - makes sense; I think? 🤔

One more thing I would like to check is do we want to add any items to a deny-list for licenses?

Yes, it probably makes sense.

The main ones are GPL-, AGPL- and LGPL-* , but the full list is on Full list is on https://community.finos.org/docs/governance/software-projects/license-categories/#category-x

@JamieSlome
Copy link
Member Author

We are unable to configure both allow-licenses and deny-licenses at the same time (as shown in the PR above).

We can proceed with closing this issue as all of the requirements have been met. Thank you @maoo ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants