Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deny-licenses list with Category X SPDX identifiers ⚖️ #522

Conversation

JamieSlome
Copy link
Member

Closes #518

Category X licenses are not compatible with Apache-2.0 and so are restricted from usage in dependencies via the Dependency Review GitHub Action 👍

@JamieSlome JamieSlome requested a review from maoo April 9, 2024 12:58
@JamieSlome JamieSlome self-assigned this Apr 9, 2024
Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit a199daa
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66153cd9f080c5000864b670

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.35%. Comparing base (be4c4dc) to head (a199daa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   57.35%   57.35%           
=======================================
  Files          39       39           
  Lines        1060     1060           
=======================================
  Hits          608      608           
  Misses        452      452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member Author

Not required as you can only specific one of allow-licenses or deny-licenses. Therefore, all Category X licenses are treated as denied, unless added to the allowed list 👍

Closing this pull request 🍰

@JamieSlome JamieSlome closed this Apr 9, 2024
@JamieSlome JamieSlome deleted the 518-review-allowed-licenses-for-dependencies-introduced-to-the-codebase branch April 9, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review allowed licenses for dependencies introduced to the codebase 🔍
1 participant