Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit usage of dependencies with CC-BY-4.0 license ⚖️ #513

Closed
wants to merge 1 commit into from

Conversation

JamieSlome
Copy link
Member

Unblocks CI for #506 & #482

(cc) @msagi @coopernetes

@JamieSlome JamieSlome added the bug Something isn't working label Apr 5, 2024
@JamieSlome JamieSlome requested a review from maoo April 5, 2024 09:18
@JamieSlome JamieSlome self-assigned this Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit b1894de
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/660fc1cca58e200008dfe064

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.35%. Comparing base (afe4ff4) to head (b1894de).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   57.35%   57.35%           
=======================================
  Files          39       39           
  Lines        1060     1060           
=======================================
  Hits          608      608           
  Misses        452      452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member Author

@maoo has raised that CC-BY-4.0 is not compatible with the Apache-2.0 license, as described in Category X:

https://community.finos.org/docs/governance/software-projects/license-categories/#category-x

@maoo
Copy link
Member

maoo commented Apr 5, 2024

@JamieSlome - my suggestion would be to:

  1. revert your change
  2. in website/package.json replace dependencies { with devDependencies {
  3. in .github/workflows/dependency-review.yml remove development from fail-on-scope

Step 2 is ok because we don't ship any code from the website folder, we only use it to run docusaurus build (from Netlify).

@JamieSlome
Copy link
Member Author

No longer want to permit usage of dependencies with CC-BY-4.0 due to incompatibility with Apache-2.0 license 👍

@JamieSlome JamieSlome closed this Apr 5, 2024
@JamieSlome JamieSlome deleted the fix/allow-CC-BY-4.0 branch April 5, 2024 09:45
@JamieSlome
Copy link
Member Author

@maoo - implemented your requested change in #514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants