-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: introduce UI tests with Cypress #581
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful PR ✨ One comment to address and then ready to merge ⏩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage 57.39% 57.39%
=======================================
Files 46 46
Lines 1582 1582
=======================================
Hits 908 908
Misses 674 674 ☔ View full report in Codecov by Sentry. |
@bill-n - hmm, I might have been mistaken (sorry!). It seems like Cypress can't detect the UI anymore? I wonder if we try reverting or add the steps Let me know if you agree 👍 |
@bill-n - do we still require the 'wait-on' dependency? |
@JamieSlome merge conflict resolved...thank you |
@bill-n - thank you for your contribution 👏 |
test: introduce UI tests with Cypress
Closes #571
Implemented first set of simple UI test using cypress