Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: introduce UI tests with Cypress #581

Merged
merged 20 commits into from
Jun 17, 2024
Merged

test: introduce UI tests with Cypress #581

merged 20 commits into from
Jun 17, 2024

Conversation

bill-n
Copy link
Contributor

@bill-n bill-n commented May 27, 2024

Closes #571

Implemented first set of simple UI test using cypress
cypress

Copy link

linux-foundation-easycla bot commented May 27, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit d6cbada
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/666d8bda921e8d0008678c76

@bill-n bill-n changed the title #571 UI test feat: #571 UI test May 27, 2024
@JamieSlome JamieSlome changed the title feat: #571 UI test test: introduce UI tests with Cypress May 28, 2024
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful PR ✨ One comment to address and then ready to merge ⏩

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (9f0711a) to head (d6cbada).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   57.39%   57.39%           
=======================================
  Files          46       46           
  Lines        1582     1582           
=======================================
  Hits          908      908           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member

@bill-n - hmm, I might have been mistaken (sorry!). It seems like Cypress can't detect the UI anymore? I wonder if we try reverting or add the steps npm run start and npm run build? Then localhost:3000 should be exposed for the test suite to run against.

Let me know if you agree 👍

@JamieSlome
Copy link
Member

@bill-n - do we still require the 'wait-on' dependency?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@JamieSlome
Copy link
Member

@bill-n - are you able to resolve the merge conflict? Keen to get this PR merged as it adds a lot of value to the project and gives us stability reassurance for the UI that we really need 👍

Thank you for your work @bill-n ❤️

@bill-n
Copy link
Contributor Author

bill-n commented Jun 14, 2024

@bill-n - are you able to resolve the merge conflict? Keen to get this PR merged as it adds a lot of value to the project and gives us stability reassurance for the UI that we really need 👍

Thank you for your work @bill-n ❤️

@JamieSlome merge conflict resolved...thank you

@JamieSlome JamieSlome merged commit 0ba98b2 into finos:main Jun 17, 2024
14 checks passed
@JamieSlome
Copy link
Member

@bill-n - thank you for your contribution 👏

Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
test: introduce UI tests with Cypress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement first set of simple UI tests and run in CI 🧪
2 participants