-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(analytics): add Scarf to npm install, docs, and ui #725
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@aviaviavi - thanks for the PR ❤️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
=======================================
Coverage 57.34% 57.34%
=======================================
Files 46 46
Lines 1594 1594
=======================================
Hits 914 914
Misses 680 680 ☔ View full report in Codecov by Sentry. |
@aviaviavi - are you able to resolve the merge conflict? Apologies! |
@maoo - would be keen to get your thoughts here before we merge 👍 |
conflicts resolved! |
@JamieSlome let me know if I can answer any questions here! |
Hey @aviaviavi, could you email me any relevant documentation or agreements regarding how the data gathered by Scarf will be handled? I'll bring that to the TOC to propose approval for FINOS project adoption. |
After some IRL discussions with @JamieSlome today: There are many other LF projects working with Scarf already through our partnership with the LF, so there is significant precedent here for FINOS to greenlight this too. To name just a few:
These projects across categories like cloud native, security, data, etc, and spans the LF, CNCF, LF AI, and more. If there are remaining concerns at the FINOS level, I would be happy to discuss them either directly or here. I sense there may be remaining misunderstandings about the data collection being proposed here and what the risks of concern actually are, but the goal here is to help the maintainers of git-proxy have a better understanding of project adoption in a way that does not compromise privacy or compliance posture. |
Thanks Avi! @JamieSlome could you help capture this as part of finos/technical-oversight-committee#158 |
As discussed with @JamieSlome directly, this PR adds basic usage tracking tooling with Scarf, compliant with CNCF guidelines.
There are a few code-level modifications in this PR:
As with all Scarf-based tracking, these metrics are fully anonymized and GDPR-compliant. No PII is being retained or exposed from this change.
I have the organization for git-proxy set up in Scarf, @JamieSlome as soon as you make an account I can transfer org ownership to you, and you'll be able to add any and all project maintainers.