Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dataspace analytics cache to get mapping model coverage analysis #2390

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

gayathrir11
Copy link
Contributor

@gayathrir11 gayathrir11 commented Jun 30, 2023

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: f9c9b64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@finos/legend-application-query Patch
@finos/legend-query-builder Patch
@finos/legend-graph Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-application-studio Patch
@finos/legend-manual-tests Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-studio-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #2390 (f9c9b64) into master (3d079af) will increase coverage by 0.75%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
+ Coverage   40.84%   41.60%   +0.75%     
==========================================
  Files        1548     1574      +26     
  Lines       73402    74088     +686     
  Branches    17246    17454     +208     
==========================================
+ Hits        29984    30823     +839     
+ Misses      43295    43139     -156     
- Partials      123      126       +3     
Impacted Files Coverage Δ
...n-query/src/stores/LegendQueryApplicationPlugin.ts 0.00% <ø> (ø)
...raph-manager/action/analytics/DataSpaceAnalysis.ts 3.44% <ø> (ø)
...ol/pure/DSL_DataSpace_PureGraphManagerExtension.ts 33.33% <ø> (ø)
...l/pure/v1/engine/analytics/V1_DataSpaceAnalysis.ts 26.50% <ø> (ø)
...ace/src/stores/query/DataSpaceQueryCreatorStore.ts 4.05% <0.00%> (-0.24%) ⬇️
...r/src/stores/explorer/QueryBuilderExplorerState.ts 74.20% <ø> (+0.36%) ⬆️
...e/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts 9.43% <5.55%> (-0.97%) ⬇️
...ace/src/stores/query/DataSpaceQueryBuilderState.ts 8.47% <25.00%> (+1.20%) ⬆️
...d-application-query/src/stores/QueryEditorStore.ts 33.33% <100.00%> (+0.10%) ⬆️

... and 156 files with indirect coverage changes

@gayathrir11 gayathrir11 marked this pull request as ready for review July 3, 2023 07:08
@gayathrir11 gayathrir11 requested a review from a team as a code owner July 3, 2023 07:08
@gayathrir11 gayathrir11 force-pushed the cache branch 2 times, most recently from 2cbe061 to 9bdd5d3 Compare July 3, 2023 07:44
@@ -144,6 +144,13 @@ export class V1_MappingModelCoverageAnalysisResult {
);
}

export const V1_mappingModelCoverageAnalysisResultModelSchema =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we already have V1_MappingModelCoverageAnalysisResult.serialization?

@akphi akphi merged commit 9af0f1b into finos:master Jul 14, 2023
@akphi akphi deleted the cache branch July 14, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants