Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension mechanism for query chat mode #2424

Merged
merged 6 commits into from
Jul 14, 2023

Conversation

Humaira-Hossain
Copy link
Contributor

@Humaira-Hossain Humaira-Hossain commented Jul 11, 2023

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)
Chat Mode modal Status bar new button
chat.mode.screen.recording.mov

@Humaira-Hossain Humaira-Hossain requested a review from a team as a code owner July 11, 2023 10:31
@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

🦋 Changeset detected

Latest commit: 257c508

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@finos/legend-art Patch
@finos/legend-query-builder Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio Patch
@finos/legend-application Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@gayathrir11 gayathrir11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR title!

@Humaira-Hossain Humaira-Hossain changed the title Humaira query chat ext Add extension mechanism for query chat mode Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2424 (257c508) into master (d06b37a) will increase coverage by 0.00%.
The diff coverage is 19.04%.

@@           Coverage Diff           @@
##           master    #2424   +/-   ##
=======================================
  Coverage   41.28%   41.28%           
=======================================
  Files        1542     1545    +3     
  Lines       73119    73212   +93     
  Branches    17273    17303   +30     
=======================================
+ Hits        30185    30228   +43     
- Misses      42809    42859   +50     
  Partials      125      125           
Impacted Files Coverage Δ
packages/legend-art/src/icon/Icon.ts 0.00% <0.00%> (ø)
.../legend-query-builder/src/components/QueryChat.tsx 7.69% <7.69%> (ø)
...gend-query-builder/src/stores/QueryBuilderState.ts 68.80% <33.33%> (-0.47%) ⬇️
...gend-query-builder/src/components/QueryBuilder.tsx 71.51% <50.00%> (-0.54%) ⬇️

... and 10 files with indirect coverage changes

Copy link
Contributor

@akphi akphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments on the TODO, but knowing this can help unblock you, we will merge it for now, let's revisit when you have time later. Thanks for your contribution!

);

return (
<Dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: I think it'd be probably better if we use a popover like virtual assistant rather than blocking modal, so let's update to that later

Comment on lines +36 to +37
const extraQueryChatConfigurations = applicationStore.pluginManager
.getApplicationPlugins()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: let's rethink this afterwards, this extension mechanism doesn't sit quite right, do we plan to have multiple chat mode support or so? I think we should consider unify this and integrate it with the virtual assistant eventually when we introduce extension mechanism for the virtual assistant

@akphi
Copy link
Contributor

akphi commented Jul 13, 2023

@Humaira-Hossain did you complete the EasyCLA sign up?

@akphi akphi merged commit 01b2c64 into finos:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants