-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension mechanism for query chat mode #2424
Conversation
🦋 Changeset detectedLatest commit: 257c508 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the PR title!
packages/legend-query-builder/src/stores/QueryBuilder_LegendApplicationPlugin_Extension.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2424 +/- ##
=======================================
Coverage 41.28% 41.28%
=======================================
Files 1542 1545 +3
Lines 73119 73212 +93
Branches 17273 17303 +30
=======================================
+ Hits 30185 30228 +43
- Misses 42809 42859 +50
Partials 125 125
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments on the TODO, but knowing this can help unblock you, we will merge it for now, let's revisit when you have time later. Thanks for your contribution!
); | ||
|
||
return ( | ||
<Dialog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: I think it'd be probably better if we use a popover like virtual assistant rather than blocking modal, so let's update to that later
const extraQueryChatConfigurations = applicationStore.pluginManager | ||
.getApplicationPlugins() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: let's rethink this afterwards, this extension mechanism doesn't sit quite right, do we plan to have multiple chat mode support or so? I think we should consider unify this and integrate it with the virtual assistant eventually when we introduce extension mechanism for the virtual assistant
@Humaira-Hossain did you complete the EasyCLA sign up? |
Summary
How did you test this change?
chat.mode.screen.recording.mov