Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pure ide: improvements #3643

Merged
merged 2 commits into from
Nov 3, 2024
Merged

pure ide: improvements #3643

merged 2 commits into from
Nov 3, 2024

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Nov 3, 2024

No description provided.

Copy link

changeset-bot bot commented Nov 3, 2024

🦋 Changeset detected

Latest commit: eb7bb27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@finos/legend-application-pure-ide Patch
@finos/legend-application Patch
@finos/legend-data-cube Patch
@finos/legend-dev-utils Patch
@finos/legend-lego Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 692 lines in your changes missing coverage. Please review.

Project coverage is 45.44%. Comparing base (18e03b6) to head (eb7bb27).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...es/legend-application/src/stores/terminal/XTerm.ts 0.00% 163 Missing ⚠️
...ide/src/components/editor-group/PureFileEditor.tsx 0.00% 156 Missing ⚠️
...ponents/command-center/SelectPCTAdapterCommand.tsx 0.00% 111 Missing and 1 partial ⚠️
...nd-application-pure-ide/src/stores/PureIDEStore.ts 0.00% 79 Missing ⚠️
...application-pure-ide/src/stores/FileEditorState.ts 0.00% 36 Missing ⚠️
...application-pure-ide/src/stores/TestRunnerState.ts 0.00% 29 Missing ⚠️
...de/src/components/side-bar/ConceptTreeExplorer.tsx 0.00% 25 Missing ⚠️
.../src/components/side-bar/DirectoryTreeExplorer.tsx 0.00% 25 Missing ⚠️
...e/src/stores/view/grid/DataCubeGridQueryBuilder.ts 0.00% 18 Missing ⚠️
...pplication-pure-ide/src/server/PureServerClient.ts 0.00% 16 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3643      +/-   ##
==========================================
- Coverage   45.68%   45.44%   -0.24%     
==========================================
  Files        2172     2173       +1     
  Lines      376108   376722     +614     
  Branches    16237    16109     -128     
==========================================
- Hits       171829   171213     -616     
- Misses     203558   204498     +940     
- Partials      721     1011     +290     
Files with missing lines Coverage Δ
...application-pure-ide/src/stores/TextSearchState.ts 0.00% <0.00%> (ø)
...nd-application-pure-ide/src/components/PureIDE.tsx 0.00% <0.00%> (ø)
...pplication-pure-ide/src/server/models/Execution.ts 0.00% <0.00%> (ø)
...lication-pure-ide/src/server/models/ConceptTree.ts 0.00% <0.00%> (ø)
...ide/src/components/panel-group/TestRunnerPanel.tsx 0.00% <0.00%> (ø)
...nd-application-pure-ide/src/server/models/Usage.ts 0.00% <0.00%> (ø)
...end-application-pure-ide/src/server/models/Test.ts 0.00% <0.00%> (ø)
...pplication-pure-ide/src/server/PureServerClient.ts 0.00% <0.00%> (ø)
...e/src/stores/view/grid/DataCubeGridQueryBuilder.ts 0.00% <0.00%> (ø)
...de/src/components/side-bar/ConceptTreeExplorer.tsx 0.00% <0.00%> (ø)
... and 7 more

... and 308 files with indirect coverage changes

@akphi akphi marked this pull request as ready for review November 3, 2024 23:01
@akphi akphi requested a review from a team as a code owner November 3, 2024 23:01
@akphi akphi merged commit fa63201 into finos:master Nov 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants