Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace type string with generic type in protocol (part 1) #3664

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented Nov 19, 2024

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: 5fc78d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@finos/legend-server-showcase-deployment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-query-builder Patch
@finos/legend-shared Patch
@finos/legend-graph Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-application-studio Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-repl Patch
@finos/legend-application Patch
@finos/legend-art Patch
@finos/legend-code-editor Patch
@finos/legend-data-cube Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-extension-tracer-zipkin Patch
@finos/legend-lego Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-server-showcase Patch
@finos/legend-storage Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-repl-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MauricioUyaguari MauricioUyaguari force-pushed the genType branch 2 times, most recently from c2c221d to 1e26b3d Compare November 20, 2024 01:23
@MauricioUyaguari MauricioUyaguari changed the title x replace type string with generic type in protocol Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 579 lines in your changes missing coverage. Please review.

Project coverage is 0.36%. Comparing base (f5ad6d7) to head (2090960).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...serializationHelpers/V1_TypeSerializationHelper.ts 0.00% 195 Missing and 1 partial ⚠️
...rializationHelpers/V1_DomainSerializationHelper.ts 0.00% 69 Missing ⚠️
...nsformation/pureGraph/from/V1_DomainTransformer.ts 0.00% 37 Missing ⚠️
...lizationHelpers/V1_ValueSpecificationSerializer.ts 0.00% 31 Missing ⚠️
...1/model/packageableElements/type/V1_GenericType.ts 0.00% 29 Missing and 1 partial ⚠️
...anager/protocol/pure/v1/helpers/V1_DomainHelper.ts 0.00% 21 Missing ⚠️
...protocol/pure/v1/model/relation/V1_RelationType.ts 0.00% 21 Missing ⚠️
...ers/V1_RawValueSpecificationSerializationHelper.ts 0.00% 21 Missing ⚠️
...ion/pureGraph/to/helpers/V1_DomainBuilderHelper.ts 0.00% 20 Missing ⚠️
.../pure/v1/model/packageableElements/type/V1_Type.ts 0.00% 18 Missing and 1 partial ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3664      +/-   ##
==========================================
- Coverage    0.36%    0.36%   -0.01%     
==========================================
  Files        2174     2177       +3     
  Lines      377005   377504     +499     
  Branches     2253     2265      +12     
==========================================
  Hits         1374     1374              
- Misses     373464   373960     +496     
- Partials     2167     2170       +3     
Files with missing lines Coverage Δ
...gend-query-builder/src/stores/QueryBuilderState.ts 0.00% <ø> (ø)
packages/legend-graph/src/graph/MetaModelConst.ts 0.00% <0.00%> (ø)
packages/legend-graph/src/index.ts 0.00% <0.00%> (ø)
...ol/pure/v1/model/valueSpecification/V1_Variable.ts 0.00% <0.00%> (ø)
...on/pureGraph/to/V1_RawValueSpecificationBuilder.ts 0.00% <0.00%> (ø)
...egend-shared/src/application/SerializationUtils.ts 0.00% <0.00%> (ø)
...eGraph/from/V1_RawValueSpecificationTransformer.ts 0.00% <0.00%> (ø)
...pureGraph/from/V1_ValueSpecificationTransformer.ts 0.00% <0.00%> (ø)
.../pureGraph/to/helpers/V1_MilestoneBuilderHelper.ts 0.00% <0.00%> (ø)
packages/legend-graph/src/graph/Core_HashUtils.ts 0.00% <0.00%> (ø)
... and 21 more
---- 🚨 Try these New Features:

@MauricioUyaguari MauricioUyaguari force-pushed the genType branch 7 times, most recently from c6f5d29 to d8d748e Compare November 20, 2024 22:19
@MauricioUyaguari MauricioUyaguari changed the title replace type string with generic type in protocol replace type string with generic type in protocol (part 1) Nov 20, 2024
@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review November 20, 2024 23:06
@MauricioUyaguari MauricioUyaguari requested a review from a team as a code owner November 20, 2024 23:06
@MauricioUyaguari MauricioUyaguari force-pushed the genType branch 2 times, most recently from a9e3985 to 5fc78d1 Compare November 20, 2024 23:15
@MauricioUyaguari MauricioUyaguari merged commit 483fe51 into finos:master Nov 20, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants