Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix string to genericType tests #3668

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

MauricioUyaguari
Copy link
Member

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: cd08e19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@finos/legend-extension-store-service-store Patch
@finos/legend-server-showcase-deployment Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-application-studio Patch
@finos/legend-application-query Patch
@finos/legend-query-builder Patch
@finos/legend-graph Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-application-pure-ide Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-application-repl Patch
@finos/legend-code-editor Patch
@finos/legend-data-cube Patch
@finos/legend-lego Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-repl-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.57%. Comparing base (4f1a434) to head (cd08e19).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3668       +/-   ##
===========================================
+ Coverage    0.36%   45.57%   +45.20%     
===========================================
  Files        2177     2179        +2     
  Lines      377504   377554       +50     
  Branches     2265    16272    +14007     
===========================================
+ Hits         1374   172053   +170679     
+ Misses     373960   204487   -169473     
+ Partials     2170     1014     -1156     
Files with missing lines Coverage Δ
...rializationHelpers/V1_DomainSerializationHelper.ts 99.77% <100.00%> (+99.77%) ⬆️
...ers/V1_RawValueSpecificationSerializationHelper.ts 70.41% <100.00%> (+70.41%) ⬆️
...serializationHelpers/V1_TypeSerializationHelper.ts 88.26% <100.00%> (+88.26%) ⬆️

... and 1472 files with indirect coverage changes

---- 🚨 Try these New Features:

@MauricioUyaguari MauricioUyaguari changed the title Gen type fix string to generic type json Nov 21, 2024
@MauricioUyaguari MauricioUyaguari changed the title fix string to generic type json fix string to generic tests Nov 21, 2024
@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review November 21, 2024 15:28
@MauricioUyaguari MauricioUyaguari requested a review from a team as a code owner November 21, 2024 15:28
@MauricioUyaguari MauricioUyaguari changed the title fix string to generic tests fix string to genericType tests Nov 21, 2024
@MauricioUyaguari MauricioUyaguari merged commit 7d7a209 into finos:master Nov 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants