Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/email hyperlink contributing guide #838

Closed

Conversation

deepdik
Copy link

@deepdik deepdik commented Nov 14, 2024

Updated broken link reported in #836

- Replaced `Files.readAllLines()` with `Files.lines()` to enable lazy loading, improving memory efficiency and performance, especially for large files.
- Added a try-with-resources block to ensure the stream is closed automatically after use.
- Streamlined comment filtering by processing lines directly and joining them into a single string without intermediate storage.

This optimization minimizes memory usage and enhances performance by avoiding the overhead of loading the entire file into memory at once.
Optimize file reading by switching to stream-based comment filtering
Updated broken link reported in finos#836

finos#836
@deepdik deepdik requested a review from a team as a code owner November 14, 2024 04:18
@finos-admin
Copy link
Member

This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

@finos-admin
Copy link
Member

This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants