Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert back to the most direct mapping from Morphir to Scala #163

Closed
AttilaMihaly opened this issue Sep 22, 2020 · 0 comments
Closed

Revert back to the most direct mapping from Morphir to Scala #163

AttilaMihaly opened this issue Sep 22, 2020 · 0 comments
Assignees
@AttilaMihaly
Milestone
Reliable Scala co...

Comments

@AttilaMihaly
Copy link
Member

AttilaMihaly commented Sep 22, 2020 •
edited
Loading

The recent attempt to bring the generated classes closer to the OOP style highlighted multiple issues. Until we find a consistent approach to fixing those issues we should revert back to the most direct mapping possible so there will be no methods generated and all function calls will be curried.
@AttilaMihaly AttilaMihaly self-assigned this Sep 22, 2020
AttilaMihaly added a commit to AttilaMihaly/morphir-elm that referenced this issue Sep 22, 2020
@AttilaMihaly
Temporarily revert back to uncurried calls until we come up with a co…
ff52ec4 
…nsistent strategy for translating function calls to Scala. finos#163
@AttilaMihaly AttilaMihaly mentioned this issue Sep 22, 2020
Merged
@AttilaMihaly AttilaMihaly changed the title Type aliases don't have the required methods in the generates Scala code Revert back to the most direct mapping from Morphir to Scala Oct 2, 2020
AttilaMihaly added a commit to AttilaMihaly/morphir-elm that referenced this issue Oct 2, 2020
@AttilaMihaly
Reverted function to method mapping. finos#163
af37fd6
AttilaMihaly added a commit that referenced this issue Oct 2, 2020
@AttilaMihaly
Merge pull request #168 from AttilaMihaly/direct-mapping-to-scala
a0c3ae0 
Reverted function to method mapping. #163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AttilaMihaly AttilaMihaly

Labels
None yet
Projects
None yet
Milestone
Reliable Scala code generation
Development

No branches or pull requests
1 participant
@AttilaMihaly