Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release #1128

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Fix release #1128

merged 5 commits into from
Dec 19, 2023

Conversation

DamianReeves
Copy link
Member

…affects npm pack

NPM uses the npm-packlist package to create the package to create or publish a npm package. As of version 6.0.0 of npm-packlist root level ignore patterns in .gitignore are ignored when you use files in package.json (however nested are not ignored).

Issues were arising when publishing because cli2/.gitignore contained the lib folder which is actually needed in the deploy. Because we want to ignore cli2/lib from git because it is generated, but we DO want to include the folder in the package, we need to add cli2/lib/ to the root .gitignore file.

Also since it is not clear what version of Node folks are using, I've also added an .nvmrc file which is currently set to lts/hydrogen (version 18.x) which is an LTS version in Maintenance mode through June 2026.

Finally, updated the GitHub actions to also use 18.x

Terms

THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE TERMS OF THE CCLA DATED 2017-11-07 WITH FINOS/LINUX FOUNDATION (FORMERLY THE SYMPHONY SOFTWARE FOUNDATION CCLA).

THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

@DamianReeves DamianReeves merged commit 6fcaa38 into finos:main Dec 19, 2023
4 checks passed
@DamianReeves DamianReeves deleted the fix-release branch December 19, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant