Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…affects npm pack
NPM uses the
npm-packlist
package to create the package to create or publish a npm package. As of version6.0.0
ofnpm-packlist
root level ignore patterns in.gitignore
are ignored when you usefiles
inpackage.json
(however nested are not ignored).Issues were arising when publishing because
cli2/.gitignore
contained thelib
folder which is actually needed in the deploy. Because we want to ignorecli2/lib
from git because it is generated, but we DO want to include the folder in the package, we need to addcli2/lib/
to the root.gitignore
file.Also since it is not clear what version of Node folks are using, I've also added an
.nvmrc
file which is currently set tolts/hydrogen
(version 18.x) which is an LTS version in Maintenance mode through June 2026.Finally, updated the GitHub actions to also use 18.x
Terms