-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial value mapping with changes around extra type argument #48
Conversation
…ve package path from module names. finos#21
� Conflicts: � src/Morphir/IR/SDK.elm
� Conflicts: � src/Morphir/IR/SDK.elm
While we are at it, I think it makes sense to switch So I think: type alias AccessControlled a =
{ access : Acccess
, value: a
}
type Access
= Public
| Private should become: type AccessControlled a
= Public a
| Private a |
It was exactly what you suggest previously but it was very painful to work with so I changed it: c22e947#diff-aa5c2f490fc2bfa6d2d09f081b81242c |
So I find it weird having the Types at the top level It feels like the following should be in an appropriate folder, otherwise they are just random toplevel things:
Also some of these seem like the belong as part of the SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cosmetic change requests
I'm open for anything. Can you suggest how would you change it specifically? My strategy is to go with the simplest approach and then refactor if needed rather to think about organizing the code upfront. |
…s#48) * Add support for Snowpark generation of basic PatternMatch cases The following cases are supported: - Cases with literal values - Cases with constructors of union types without parameters
…s#48) * Add support for Snowpark generation of basic PatternMatch cases The following cases are supported: - Cases with literal values - Cases with constructors of union types without parameters
…s#48) * Add support for Snowpark generation of basic PatternMatch cases The following cases are supported: - Cases with literal values - Cases with constructors of union types without parameters
…s#48) * Add support for Snowpark generation of basic PatternMatch cases The following cases are supported: - Cases with literal values - Cases with constructors of union types without parameters
closes #5 closes #46
#25