LZ4 compression for Apache Arrow #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
reviewed
Aug 14, 2023
| @@ -3,7 +3,7 @@ project(psp) | |||
| include(CheckCCompilerFlag) | |||
|
|
|||
| set(CMAKE_BUILD_TYPE "Release") | |||
| set(CMAKE_CXX_STANDARD 14) | |||
| set(CMAKE_CXX_STANDARD 17) | |||
There was a problem hiding this comment.
should update/remove gnu flag to match:
perspective/cpp/perspective/CMakeLists.txt
Line 414 in 88e0878
| @@ -509,7 +509,7 @@ set(PYTHON_SOURCE_FILES ${SOURCE_FILES} | |||
| ) | |||
|
|
|||
| set(WASM_SOURCE_FILES ${SOURCE_FILES} | |||
There was a problem hiding this comment.
should remove whole block if not used anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds LZ4 compression to Perspective's Apache Arrow read/write support, which also makes Perspective compatible with e.g.
pyarrow.feather.write_feather()IPC methods which default to this compression codec. This PR addresses issues from #2337, adding:v12.0.0to_arrow(),compression, which can be"lz4"ornull/None(for JavaScript/Python, respectively). This option defaults to"lz4".This PR is a breaking change, as the
compressionoption causes default.to_arrow()output to be incompatible with older Perspective versions. To backport, set this option tonull/None:JavaScript:
Python:
full build