Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter number validation with trailing zeroes #2353

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

texodus
Copy link
Member

@texodus texodus commented Aug 31, 2023

Fixes #2284 by short-circuiting validation if the parsed values are equivalent, e.g. in the reported example, 1 == 1.0 so this keyboard sequence will not trigger further validation or render.

@texodus texodus added the bug Concrete, reproducible bugs label Aug 31, 2023
@texodus texodus merged commit 285a76c into master Aug 31, 2023
10 of 11 checks passed
@texodus texodus deleted the fix-filter-validation branch August 31, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant