Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title synchronization in PerspectiveWidget #2355

Conversation

cyril-acquah80
Copy link
Contributor

The perspective-config-update event is not triggered when the title is changed and that is the cause of the issue. The changes in this PR listens to title change events and dispatches config update event.

https://github.com/finos/perspective/blob/master/packages/perspective-jupyterlab/src/js/view.js#L59

this.luminoWidget.viewer.addEventListener(
    "perspective-config-update",
    this._synchronize_state
);

Fixes #2131

perspective-google-chrome-2023-09-04-09-34-38_6gh1rr8d.mp4

@cyril-acquah80
Copy link
Contributor Author

cyril-acquah80 commented Sep 7, 2023

Please @texodus / @timkpaine, can you kindly review my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

title does not synchronize to PerspectiveWidget when changed
1 participant