Calculate group_by in parallel
#2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
sparse-tree-parallel
branch
2 times, most recently
from
f608e12
to
6c53cb6
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
force-pushed
the
sparse-tree-parallel
branch
from
6c53cb6
to
b09659c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parallelizes column population during
group_bytree calculation. The result is a substantial improvement to the wall-clock runtime ofView()creation using this field, which scales with the # of cores andViewcolumns. For example, in an 8-thread pool tested on with 50k rows * 20 columns dataset grouped by astringcolumn, the wall clock improvements is ~2x.