Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<TAB> key press inserts '\t' character in code editor as indentation. #2779

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

onesimus-wiafe
Copy link
Contributor

I have reopened this PR after #2747 for issue #2703.

  1. On the TAB key press, \t is inserted into the caret's position.
  2. There is a test to confirm the behavior.

Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
@texodus
Copy link
Member

texodus commented Oct 17, 2024

Thanks for the PR!

Can you please rebase this on master branch and remove the file results.tar.gz from commit 7ca2860 ? I've rebased your branch with the changes here which you can copy, or if you don't care about the PR attribution I can cherry-pick these changes onto a new branch that does not conflict (your commits will still be attributed correctly).

@texodus texodus added the bug Concrete, reproducible bugs label Oct 17, 2024
@onesimus-wiafe onesimus-wiafe force-pushed the bug/insert_tab_on_tab_key branch 2 times, most recently from a42bc85 to 6c8a1df Compare October 18, 2024 10:41
@onesimus-wiafe
Copy link
Contributor Author

made the changes @texodus

@texodus texodus merged commit 83bcdfa into finos:master Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants