Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aarch64 Mac runners to test_python, restore PSP_ARCH dev behavior #2802

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Add aarch64 Mac runners to test_python, restore PSP_ARCH dev behavior #2802

merged 2 commits into from
Oct 25, 2024

Commits on Oct 23, 2024

  1. perspective-server: ignore PKG_ARCH when unset 

    this matches the behavior pre-toolchain patch -- if PSP_ARCH is not set,
then no toolchain file is defined, and the build proceeds without
setting `CMAKE_OSX_ARCHITECTURES`

Signed-off-by: Tom Jakubowski <tom@prospective.dev>
    @tomjakubowski
    tomjakubowski committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9eee20f View commit details
    Browse the repository at this point in the history

  2. Add macos-14 to test_python matrix 

    macos-14 is aarch64 with Apple silicon.  This lets us test the aarch64
wheel in CI

Will try a follow up to see if the builds are any faster on macos-14.
Will want to double check we still have a good value for
`CMAKE_OSX_DEPLOYMENT_TARGET`/`MACOSX_DEPLOYMENT_TARGET` after upgrading
the builders

Signed-off-by: Tom Jakubowski <tom@prospective.dev>

new crack at build matrix

verified this one with a model of the behavior in github's docs.  would
be cool if I knew how to get github to print the job configurations
before the job actually runs
    @tomjakubowski
    tomjakubowski committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    89964b6 View commit details
    Browse the repository at this point in the history