Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pyarrow import and make clear(er) error message #2848

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Nov 14, 2024

catch the import error and re-raise with a clear message that perspective is requiring this import explicitly (its a bit confusing in a normal stack trace), fixes #2847

Screenshot 2024-11-14 at 15 13 41

With this change:
Screenshot 2024-11-15 at 14 30 12

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine timkpaine marked this pull request as ready for review November 15, 2024 19:28
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 6d65d5f into master Nov 18, 2024
24 of 25 checks passed
@texodus texodus deleted the tkp/checkimp branch November 18, 2024 06:12
@texodus texodus added the internal Internal refactoring and code quality improvement label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear error when trying to pass pandas into perspective table
2 participants