-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-compiled JavaScript artifacts for Perspective package #378
Conversation
@texodus any ideas why the https://travis-ci.org/jpmorganchase/perspective/jobs/478847521#L870 |
78362b6
to
16adf83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be some issues with this, notably that the example webpack project no longer compiles. Might I recommend fixing this example, which is both necessary and a good demonstration of what this refactor looks like from a consuming developer's standpoint?
@texodus Updated the PR with all the comments we've discussed in person and on here. Still running into this issue when running the webpack example locally though: |
This PR does two things to enhance and improve the development workflow for apps running on the webpack plugin provided by
@jpmorganchase/perspective
:@babel/cli
). This reduces the overhead on webpack for end users since it doesn't need to run babel itself on every build for the package anymore.CJS
module with it's dependencies externalised.