Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FileBasedRosettaConfigurationProvider.java #754

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimonCockx
Copy link
Contributor

Please include a summary of the change and the issue/story number.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Copy link

netlify bot commented May 17, 2024

Deploy Preview for peaceful-licorice-6cd1ec failed. Why did it fail? →

Name Link
🔨 Latest commit e5f3d36
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-licorice-6cd1ec/deploys/6647679d9673660008e5bbe5

@@ -54,7 +54,7 @@ protected RosettaConfiguration readConfigFromFile() {
if (file != null) {
return mapper.readValue(file, RosettaConfiguration.class);
}
LOGGER.info("No configuration file was found. Falling back to the default configuration.");
LOGGER.debug("No configuration file was found. Falling back to the default configuration.");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative: only log once instead of for every Rosetta file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant