New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter Maven plugin #864

Open

maria77102 wants to merge 27 commits into finos:main from REGnosys:formatter-maven-plugin

Contributor

maria77102 commented Nov 7, 2024

This PR deals with the 4th point of issue #858.

Type of change

New feature (non-breaking change which adds functionality)

maria77102 and others added 20 commits

October 23, 2024 13:19


          Created formatter interface

cf5ef6e


          Implement interface + first Test

b124d3a


          Fix formatting test + implementation

777832c


          Enhanced test suite

b7d3057


          Implement suggested changes

d2c7c2c


          Improved interface methods/exception handling and added logging

619d38c


          Added formatting tool method

a57b7ee


          Add dependencies for logging in tools project

c8bc3b4


          Improve implementation of command line tool

6e09f6d


          Formatting java code

abca32a


          Made formatting happen in-memory

5591d3d


          Update logs when resource saved

b36f60c


          Fixed logger class name

2f84974


          Starting code for formatter plugin

7cf4bd2


          Merge branch 'main' into formatter-maven-plugin

116995c


          Incorporate 'format' goal in existing plugin

b65a756


          Cleanup files

6ca9578


          Add test cases for edge cases and unusual behavior

6e23194


          Update code to deal with runtime exceptions

f8cd98e


          Fix formatting errors with Choice and parenthesis

956fb9c

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/formatting2/RosettaExpressionFormatter.xtend Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/formatting2/RosettaFormatter.xtend Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/formatting2/RosettaFormatter.xtend Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/formatting2/RosettaFormatter.xtend Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/formatting2/XtextResourceFormatter.java Outdated Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-maven-plugin/src/main/java/com/regnosys/rosetta/maven/ResourceFormatterMojo.java Show resolved Hide resolved

SimonCockx reviewed

View reviewed changes

rosetta-maven-plugin/src/main/java/com/regnosys/rosetta/maven/ResourceFormatterMojo.java Show resolved Hide resolved


          Implement suggested changes

e1165ac

maria77102 marked this pull request as ready for review

November 20, 2024 09:28


          Merge branch 'main' into formatter-maven-plugin

ebcb6c2

SimonCockx reviewed

View reviewed changes

rosetta-lang/src/main/java/com/regnosys/rosetta/formatting2/XtextResourceFormatter.java Outdated Show resolved Hide resolved


          Fix comment

a497664

SimonCockx reviewed

View reviewed changes

rosetta-maven-plugin/src/main/java/com/regnosys/rosetta/maven/ResourceFormatterMojo.java Outdated Show resolved Hide resolved

maria77102 and others added 4 commits

November 21, 2024 10:41


          Implement suggestion

60038cd


          Fix only exists serialization issue

29d5c03


          Merge branch 'main' into formatter-maven-plugin

a002f3e


          Cleanup test

0a6f1a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet