Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No button display support on Help Page in v8+ #259

Closed
pankaj-a-khandelwal-db opened this issue Nov 20, 2021 · 0 comments · Fixed by #268
Closed

No button display support on Help Page in v8+ #259

pankaj-a-khandelwal-db opened this issue Nov 20, 2021 · 0 comments · Fixed by #268
Labels
chat-workflow

Comments

@pankaj-a-khandelwal-db
Copy link
Contributor

Feature Request

Description of Problem:

  • We should be able to configure addition of button to default Help page against text commands
  • Pre v8 framework, allowed users to directly click buttons from /help displayed Help Page
  • Buttons, if configured, were displayed as 3rd column on Help Page
sureshrupnar added a commit that referenced this issue Nov 28, 2021
@sureshrupnar
No button display support on Help Page in v8+ #259
e9c93d9
@sureshrupnar sureshrupnar linked a pull request Nov 28, 2021 that will close this issue
#259 #268
Merged
sureshrupnar added a commit that referenced this issue Nov 29, 2021
@sureshrupnar
Merge pull request #268 from finos/suresh_master
a5f3318 
#259
deutschebank-sync pushed a commit to deutschebank/spring-bot that referenced this issue Jan 17, 2022
@sureshrupnar
Merge pull request finos#17 in SYMPHONYP/symphony-java-toolkit from m…
b1afc31 
…aster to production

* commit '9d21049227245d80f43277d981100bc0b9edb528': (180 commits)
  Update pom.xml
  fix for finos#271
  Update upgrading.md
  version bumped to 8.0.6
  added buttonName as button.
  No button display support on Help Page in v8+ finos#259
  to get git access just add one blank line
  For ChatRequest and ChatButton - room exclusion is not present finos#264
  ChatRequest is visible in all rooms even if restricted with "rooms" attribute of @ChatRequesrt finos#262
  reverted
  worked on Rob's review comment
  Search User from global POD finos#260
  Fix for finos#258
  Fix for finos#256
  disabled maven deploy for KoreAI
  Update CHANGES.md
  minior version change
  Update KoreAIRequesterImpl.java
  Update KoreAIRequesterImpl.java
  Update CHANGES.md
  ...
deutschebank-sync pushed a commit to deutschebank/spring-bot that referenced this issue Jan 17, 2022
@sureshrupnar
Merge pull request finos#21 in SYMPHONYP/symphony-java-client-staging…
d91af4b 
… from SYMPHONYP/symphony-java-toolkit:production to production

* commit 'b1afc31936668e9254dc18f95ae2cc8a81251c94': (180 commits)
  Update pom.xml
  fix for finos#271
  Update upgrading.md
  version bumped to 8.0.6
  added buttonName as button.
  No button display support on Help Page in v8+ finos#259
  to get git access just add one blank line
  For ChatRequest and ChatButton - room exclusion is not present finos#264
  ChatRequest is visible in all rooms even if restricted with "rooms" attribute of @ChatRequesrt finos#262
  reverted
  worked on Rob's review comment
  Search User from global POD finos#260
  Fix for finos#258
  Fix for finos#256
  disabled maven deploy for KoreAI
  Update CHANGES.md
  minior version change
  Update KoreAIRequesterImpl.java
  Update KoreAIRequesterImpl.java
  Update CHANGES.md
  ...
deutschebank-sync pushed a commit to deutschebank/spring-bot that referenced this issue Jan 17, 2022
@sureshrupnar
Merge pull request finos#22 in SYMPHONYP/symphony-java-client-staging…
60a5b1b 
… from production to master

* commit 'd91af4bb26d5727c3ba0ee45c4e5a2bc9ee9ca0f':
  Update pom.xml
  fix for finos#271
  Update upgrading.md
  version bumped to 8.0.6
  added buttonName as button.
  No button display support on Help Page in v8+ finos#259
  to get git access just add one blank line
  For ChatRequest and ChatButton - room exclusion is not present finos#264
  ChatRequest is visible in all rooms even if restricted with "rooms" attribute of @ChatRequesrt finos#262
  reverted
  worked on Rob's review comment
  Search User from global POD finos#260
  Fix for finos#258
  Fix for finos#256
  disabled maven deploy for KoreAI
  Update CHANGES.md
  minior version change
  Update KoreAIRequesterImpl.java
  Update KoreAIRequesterImpl.java
deutschebank-sync pushed a commit to deutschebank/spring-bot that referenced this issue Mar 3, 2022
@sureshrupnar
No button display support on Help Page in v8+ finos#259
0e9bfb6
deutschebank-sync pushed a commit to deutschebank/spring-bot that referenced this issue Mar 3, 2022
@sureshrupnar
Merge pull request finos#268 from finos/suresh_master
41381b9 
finos#259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chat-workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#259 finos/spring-bot
2 participants
@pankaj-a-khandelwal-db @sureshrupnar