-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade people-service to .NET 8 #111
Conversation
- Update NuGet dependencies - Update Docker image version to dotnet:8.0
|
/easycla |
@ztanczos I tried to build this directly in a codespace for this branch using 'dotnet build' and it seems the microsoft devcontainer image by default has the CLI using DotNet 7.0, so it can't build targeting net8. That said, while running dotnet --installed-runtimes I do see the .net 8 runtime present. I'm not an expert with .net but this CLI build used to work fine before. Do we need a new feature added to the devcontainer so the CLI builds the projects by default? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per comment added on the main PR - what needs to be done so the projects can be built by default in the codespace? (right now it seems dotnet --version returns 7.x and complains when trying to build)
@DovOps If I try using the 'dev' version of universal devcontainer then it works fine since that release already has .NET 8. Based on the conversation on the PR I believe the best would be to wait until Monday when they release to prod. |
The universal image now has .NET 8:
|
I fully rebuilt the codespaces container, and re-ran the build and ran the services and this now works. I also ran the service via Docker-Compose to confirm that works as well. |
--
THIS MATERIAL IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS Corporate Contributor License Agreement.
THIS MATERIAL IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS MATERIAL, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS MATERIAL MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.