Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to track metrics for each instance of virtual session table #1195

Closed
Tracked by #1196
naleeha opened this issue Feb 14, 2024 · 0 comments
Closed
Tracked by #1196

Need to track metrics for each instance of virtual session table #1195

naleeha opened this issue Feb 14, 2024 · 0 comments
Assignees
@junaidzm13
Labels
Bigdata bug Something isn't working server

Comments

@naleeha
Copy link
Contributor

naleeha commented Feb 14, 2024

Bug Report

Steps to Reproduce:

  1. run ignite vuu
  2. load ignite big order table twice - two instances
  3. Load Metics table

Expected Result:

Two instances of the big order table with long names that start with session:xxx

Actual Result:

One record for big order with archetype name (Ignite big order2 )

Additional Context:

Need to be careful to ensure the table menu still show the ignite table archetypes (Ignite big order2 ) and not the virtual session tables
But in Metrics, show the instances of virtual session tables but not the archetype (Ignite big order2 )

The gettable methods does not distinguish the session table name.

image
@naleeha naleeha added bug Something isn't working Bigdata server labels Feb 14, 2024
@naleeha naleeha moved this to 🆕 New in Vuu board Feb 14, 2024
@naleeha naleeha changed the title Need to track metrics for each instanced of virtual session table Need to track metrics for each instance of virtual session table Feb 14, 2024
@naleeha naleeha mentioned this issue Feb 14, 2024
Open
@junaidzm13 junaidzm13 self-assigned this Feb 22, 2024
@junaidzm13 junaidzm13 moved this from 🆕 New to 🏗 In progress in Vuu board Feb 22, 2024
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 22, 2024
@junaidzm13
finos#1195 enable metric tracking for each instance of session table
d7b3346 
- reason TBA
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 22, 2024
@junaidzm13
finos#1195 enable metric tracking for each instance of session table
a4b3f27 
- reason TBA
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 22, 2024
@junaidzm13
finos#1195 enable metric tracking for each instance of session table
193e54b 
- reason TBA
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 22, 2024
@junaidzm13
finos#1195 enable metric tracking for each instance of session table
70e4a05 
- reason TBA
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 23, 2024
@junaidzm13
finos#1195 enable metric tracking for each instance of session table
18dbd9c 
- there were two bugs that needed fixing:
  1. TableContainer.getTables() returned array where table name actually
     reflected the tableDef.name. Because of this returned session tables
     and its blueprints had same names and the metrics table only added
     one and it seemed as if we're only considering the archetype.
  2. this one was a bit more involved. First we were using tableDef.name
     to update metrics in InMemDataTable, hence, if we updated metrics for
     a session table it appeared as if we're updating for the archetype.
     Second, if we even had tried calling sessionTable.name in InMemDataTable
     to initialize the metric counters/meters it still would've not worked
     because in session table we used an instance variable `createInstant`
     (used in session-table name) which is not initialized at the time we
     call super class (InMemDataTable) constructor.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 23, 2024
@junaidzm13
finos#1195 refactor getTables and getDefinedTables methods in TableCo…
fa76df7 
…ntainer

- renames getNonSessionTables to getDefinedTables since its actual intention
  is to return unique table defs for the UI. And now it explicitly does what
  it's intended to do - filter out session tables (i.e. non-unique table defs).
- getTables actual intention is to return actual tables and not the blueprints
  for MetricsTable. That's what it explicitly does now.
- adds tests for the two methods
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 23, 2024
@junaidzm13
finos#1195 enable metric tracking for each instance of session table
4ed4783 
- there were two bugs that needed fixing:
  1. TableContainer.getTables() returned array where table name actually
     reflected the tableDef.name. Because of this returned session tables
     and its blueprints had same names and the metrics table only added
     one and it seemed as if we're only considering the archetype.
  2. this one was a bit more involved. First we were using tableDef.name
     to update metrics in InMemDataTable, hence, if we updated metrics for
     a session table it appeared as if we're updating for the archetype.
     Second, if we even had tried calling sessionTable.name in InMemDataTable
     to initialize the metric counters/meters it still would've not worked
     because in session table we used an instance variable `createInstant`
     (used in session-table name) which is not initialized at the time we
     call super class (InMemDataTable) constructor.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 23, 2024
@junaidzm13
finos#1195 refactor getTables and getDefinedTables methods in TableCo…
4433081 
…ntainer

- renames getNonSessionTables to getDefinedTables since its actual intention
  is to return unique table defs for the UI. And now it explicitly does what
  it's intended to do - filter out session tables (i.e. non-unique table defs).
- getTables actual intention is to return actual tables and not the blueprints
  for MetricsTable. That's what it explicitly does now.
- adds tests for the two methods
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 23, 2024
@junaidzm13
finos#1195 refactor getTables and getDefinedTables methods in TableCo…
bc2cf5e 
…ntainer

- renames getNonSessionTables to getDefinedTables since its actual intention
  is to return unique table defs for the UI. And now it explicitly does what
  it's intended to do - filter out session tables (i.e. non-unique table defs).
- getTables actual intention is to return actual tables and not the blueprints
  for MetricsTable. That's what it explicitly does now.
- adds tests for the two methods
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 23, 2024
@junaidzm13
finos#1195 refactor getTables and getDefinedTables TableContainer met…
bf7cda5 
…hods

- renames getNonSessionTables to getDefinedTables since its intended
  to return unique table defs for the UI. Now it explicitly does
  that by filtering out session tables (i.e. non-unique table defs).
- getTables is intended to return actual tables and not the blueprints
  for MetricsTable (for now). That's what it does now by filtering out
  blueprints.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 26, 2024
@junaidzm13
finos#1195 use sttp client instead of vertx
8b1969a 
- sttp.client4 has built-in support for stubbing
  and supports popular http clients out of the box
  with consistent API.
- So would be easier for users to replace underlying
  http technology (Akka, http4s, etc.) while making it
  very simple to stub it for our demo example.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Feb 26, 2024
@junaidzm13
finos#1195 use sttp client instead of vertx
6b02622 
- sttp.client4 has built-in support for stubbing
  and supports popular http clients out of the box
  with consistent API.
- So would be easier for users to replace underlying
  http technology (Akka, http4s, etc.) while making it
  very simple to stub it for our demo example.
chrisjstevo pushed a commit that referenced this issue Feb 26, 2024
@junaidzm13 @chrisjstevo
#1195 enable metric tracking for each instance of session table
6fe9548 
- there were two bugs that needed fixing:
  1. TableContainer.getTables() returned array where table name actually
     reflected the tableDef.name. Because of this returned session tables
     and its blueprints had same names and the metrics table only added
     one and it seemed as if we're only considering the archetype.
  2. this one was a bit more involved. First we were using tableDef.name
     to update metrics in InMemDataTable, hence, if we updated metrics for
     a session table it appeared as if we're updating for the archetype.
     Second, if we even had tried calling sessionTable.name in InMemDataTable
     to initialize the metric counters/meters it still would've not worked
     because in session table we used an instance variable `createInstant`
     (used in session-table name) which is not initialized at the time we
     call super class (InMemDataTable) constructor.
chrisjstevo pushed a commit that referenced this issue Feb 26, 2024
@junaidzm13 @chrisjstevo
#1195 refactor getTables and getDefinedTables TableContainer methods
70c9d51 
- renames getNonSessionTables to getDefinedTables since its intended
  to return unique table defs for the UI. Now it explicitly does
  that by filtering out session tables (i.e. non-unique table defs).
- getTables is intended to return actual tables and not the blueprints
  for MetricsTable (for now). That's what it does now by filtering out
  blueprints.
@junaidzm13 junaidzm13 moved this from 🏗 In progress to 👀 To be tested in QA in Vuu board Mar 1, 2024
@naleeha naleeha moved this from 👀 To be tested in QA to ✅ Done in Vuu board Mar 1, 2024
@naleeha naleeha closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junaidzm13 junaidzm13

Labels
Bigdata bug Something isn't working server
Projects
Vuu board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junaidzm13 @naleeha