Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approvedpush 20231124 basketdemofixes #1044

Merged
merged 12 commits into from
Dec 5, 2023
Merged

Approvedpush 20231124 basketdemofixes #1044

merged 12 commits into from
Dec 5, 2023

Commits on Nov 27, 2023

  1. finos#966 when updating basket trade cell value, only update if diffe… 

    …rent from current value
    @naleeha
    naleeha committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    943cfd1 View commit details
    Browse the repository at this point in the history

  2. finos#982 initial implementation of editing basket trade constituent … 

    …side
    @naleeha
    naleeha committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    674a26a View commit details
    Browse the repository at this point in the history

  3. finos#979 using unique instanceId for the basket trade separate from … 

    …basket trade name entered by user
    @naleeha
    naleeha committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b158d86 View commit details
    Browse the repository at this point in the history

  4. finos#980 adding basket trading constituent row - using menu for testing

    @naleeha
    naleeha committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2c6835f View commit details
    Browse the repository at this point in the history

  5. finos#980 removed the add row menu that was for testing, clean up and… 

    … error handling around adding row
    @naleeha
    naleeha committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    af1940d View commit details
    Browse the repository at this point in the history

  6. finos#980 returning no action for menu calls and rcp success or failu… 

    …re for rcp call
    @naleeha
    naleeha committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9d6aff7 View commit details
    Browse the repository at this point in the history

  7. finos#1010 registring ViewPortRpcSuccess

    @naleeha
    naleeha committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fd42183 View commit details
    Browse the repository at this point in the history

  8. finos#979 updated test to use basket trade instance id seperate from … 

    …basket name. Disabling tests that are in progress
    @naleeha
    naleeha committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    86c7fc0 View commit details
    Browse the repository at this point in the history

  9. finos#1010 re-naming to VP_EDIT_FAILURE and VP_RCP_FAILURE for consis… 

    …tency
    @naleeha
    naleeha committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    99cefd4 View commit details
    Browse the repository at this point in the history

  10. finos#1019 converting weighting and limit price field to a double as … 

    …json serialisation parse it as BigDecimal or Integer
    @naleeha
    naleeha committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    82931ad View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. finos#979 moved logic for generating unique basket id to the static c… 

    …lass, using that class to get generated basket trade if in tests
    @naleeha
    naleeha committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    7473d69 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. finos#980 making basket trade add constituent take in single ric as p… 

    …arsing arrays on rcp message is not supported
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    336ab9f View commit details
    Browse the repository at this point in the history