#483 add CheckboxCell renderer for boolean columns #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
junaidzm13
force-pushed
the
483-create-custom-cell-renderer-for-boolean-columns
branch
from
ca50e37
to
de0a4d3
Compare
|
This is how it looks: 
|
junaidzm13
force-pushed
the
483-create-custom-cell-renderer-for-boolean-columns
branch
5 times, most recently
from
cbf1df7
to
ad94af7
Compare
- also adds this renderer as the default for boolean columns in case no renderer is specified.
junaidzm13
force-pushed
the
483-create-custom-cell-renderer-for-boolean-columns
branch
from
ad94af7
to
b1c2c18
Compare
- also reverts the addition of prices column in simul instruments table in the previous commit.
junaidzm13
force-pushed
the
483-create-custom-cell-renderer-for-boolean-columns
branch
from
b1c2c18
to
21af6ec
Compare
heswell
approved these changes
Dec 8, 2023
junaidzm13
deleted the
483-create-custom-cell-renderer-for-boolean-columns
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed we're using two checkbox components in the code, one from
salt-dsand the other insidevuu-ui-controls/inputs. Do we plan to remove one for consistency?