VUU-333: Improve Screenshot Functionality #1076
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an open BUG tracking this issue on the html-to-image repo. The following changes are aimed at mitigating the issue with the UI freezing when taking a screenshot of a very complex layout
Changes
Before
![2](https://private-user-images.githubusercontent.com/98337074/286291835-d121b659-c3a6-432f-a6d3-3706c184991b.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Mjc3NjAsIm5iZiI6MTczOTcyNzQ2MCwicGF0aCI6Ii85ODMzNzA3NC8yODYyOTE4MzUtZDEyMWI2NTktYzNhNi00MzJmLWE2ZDMtMzcwNmMxODQ5OTFiLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE3Mzc0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBlOTE1MzYyMTZjZjdmMDdkNWE0ZjI5NmQ5MmZkYjQ3NjIwNGQ1ZDQ0M2E3N2JiZjhkYWRkMjI1OGY5NjRlMWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.iK8fn1O5WINdcHsq5Aan5L80smJDErpuh7jA7OohkDc)
![before](https://private-user-images.githubusercontent.com/98337074/287673887-047a4ab5-b17a-4d71-aba7-3200559161ee.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Mjc3NjAsIm5iZiI6MTczOTcyNzQ2MCwicGF0aCI6Ii85ODMzNzA3NC8yODc2NzM4ODctMDQ3YTRhYjUtYjE3YS00ZDcxLWFiYTctMzIwMDU1OTE2MWVlLlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE3Mzc0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRlYmU4NDY1YmQ3ZjgzYjNhYzUzMjI3MTcyZGEwZjQxMTc4NWEyZDI3YTFiYzZlMWY0NTVmN2Y4NzBiYjM3ZTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.MJl7llw4GSqyaDIR8T_xosZrA22-h8F7dM43JQYi8SM)
After
![1](https://private-user-images.githubusercontent.com/98337074/286291785-372eb226-77ec-4db6-b1ae-779d57ef2955.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Mjc3NjAsIm5iZiI6MTczOTcyNzQ2MCwicGF0aCI6Ii85ODMzNzA3NC8yODYyOTE3ODUtMzcyZWIyMjYtNzdlYy00ZGI2LWIxYWUtNzc5ZDU3ZWYyOTU1LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE3Mzc0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEyODhjYmJlYTVkZWQ4MjczMTZhMzcxMDNhNmRhZTQ2MTdiZDM1MmY5N2Y4NTc2NzQ4ZGQwOTQ5Y2Y3YWExZWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.pZKu8C466Fv1aOosnTIqmPmmkor4Q-2y1VKoIMclXnc)
![after](https://private-user-images.githubusercontent.com/98337074/287673902-99f91da5-c694-422e-a3ec-9d542ec958f3.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Mjc3NjAsIm5iZiI6MTczOTcyNzQ2MCwicGF0aCI6Ii85ODMzNzA3NC8yODc2NzM5MDItOTlmOTFkYTUtYzY5NC00MjJlLWEzZWMtOWQ1NDJlYzk1OGYzLlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE3Mzc0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMwOTdiODU4OGU4ZGZjMWNkMzhmYmJkMWZkMDYyOWQ2YjZkYWMyZTIyM2RlYzFkNzZlMWIwZjA0YTc3NGU5Y2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.TJ7AKkaN3Mfb0OSidueM4sUpX3p1Q4g89iZ5wt_BgJ4)
takeScreenshot function throws error (in this case the error is thrown because the layout is not displayed in the DOM)
![3](https://private-user-images.githubusercontent.com/98337074/286292906-295dfdca-5497-46b4-912a-e30f907cf960.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Mjc3NjAsIm5iZiI6MTczOTcyNzQ2MCwicGF0aCI6Ii85ODMzNzA3NC8yODYyOTI5MDYtMjk1ZGZkY2EtNTQ5Ny00NmI0LTkxMmEtZTMwZjkwN2NmOTYwLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDE3Mzc0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMyY2JmYWY5ZGYzMjgwMjNlNDE2ZTJlOTdiMzk1OGYyZTMwMDEyM2RjNzAwYWUyMTE1N2EzOGMxMGQ0NTFjZjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.RBK2WjqWAIOe6cdVxJJPqZK7DRcEXQnO9K3unPN54X4)
Note