manage named filters in application settings #1141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had previously added code to vuu-filters package to store named filters in application settings. This was the wrong place to do this. The FilterBar should not know or care about the fact that we might persist filters across sessions and it should not require a dependency on vuu-shell.
I have extracted this code to the FilterTable feature. The feature is responsible for loading/saving persisted state data. It now handles filters as well as other options. It also populates the context menu location 'filter-bar-menu' with saved menu items appropriate to the current tableSchema.
Opens a new question - should the filterbarmenu (the icon at far left) even be part of filterbar, we could extract that to nthe Feature as well ?
Right now, we are not doing anything with the list of named filters that can be dropped down from the filter menu. That will follow in a separate PR.
Need to decide how we present these named filters. for example
The code in vuu-shell pertaining to LayoutManagement should all be changed to refer to
Persistence
notLayout
, this has begun but there are still some entities, likeuseLayoutManager
that should beusePersistenceSomethingOrOther
The code that actually pertains to Layout (like LayoutProvider) all lives in the vuu-layout package.WIll submit seperate PR just for the renaming