Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage named filters in application settings #1141

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

heswell
Copy link
Contributor

@heswell heswell commented Jan 22, 2024

I had previously added code to vuu-filters package to store named filters in application settings. This was the wrong place to do this. The FilterBar should not know or care about the fact that we might persist filters across sessions and it should not require a dependency on vuu-shell.

I have extracted this code to the FilterTable feature. The feature is responsible for loading/saving persisted state data. It now handles filters as well as other options. It also populates the context menu location 'filter-bar-menu' with saved menu items appropriate to the current tableSchema.

Opens a new question - should the filterbarmenu (the icon at far left) even be part of filterbar, we could extract that to nthe Feature as well ?

Right now, we are not doing anything with the list of named filters that can be dropped down from the filter menu. That will follow in a separate PR.

Need to decide how we present these named filters. for example

  • what if they are already in the FilterBar, do we show them greyed out ?
  • OR do we show them as a multiselect, where the filters inn the filterbar appear as selected ?

The code in vuu-shell pertaining to LayoutManagement should all be changed to refer to Persistence not Layout, this has begun but there are still some entities, like useLayoutManager that should be usePersistenceSomethingOrOther The code that actually pertains to Layout (like LayoutProvider) all lives in the vuu-layout package.

WIll submit seperate PR just for the renaming

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit e23b517
🔍 Latest deploy log https://app.netlify.com/sites/papaya-valkyrie-395400/deploys/65b13216dbfd0f00072584f1

@heswell heswell marked this pull request as ready for review January 23, 2024 10:04
@heswell heswell merged commit ddcf73a into main Jan 24, 2024
22 checks passed
@heswell heswell deleted the named-filters-menu branch January 24, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants