#1167 refactor to use FP paradigm for schema validation logic #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
junaidzm13
force-pushed
the
1167-follow-up-small-refactor
branch
2 times, most recently
from
03f4943 to
e80e66a
Compare
naleeha
reviewed
Feb 12, 2024
...le/apache-ignite/src/main/scala/org/finos/vuu/example/ignite/schema/IgniteEntitySchema.scala
Outdated
Show resolved
Hide resolved
...pache-ignite/src/test/scala/org/finos/vuu/example/ignite/schema/IgniteEntitySchemaTest.scala
Outdated
Show resolved
Hide resolved
|
|
||
| None | ||
| externalFields | ||
| .find(field => externalSchema.schemaFields.forall(_.name != field)) |
There was a problem hiding this comment.
is there a reason to switch to forall rather than using exists?
Exists will exit early on first element it find that is a match rather than traversing the whole collection
https://stackoverflow.com/questions/59922992/when-true-does-scala-exists-stop-at-the-first-element-that-satisfies-the-predic
There was a problem hiding this comment.
forall exits early as well, so they're same in that aspect. I just find forall easier to follow in this scenario.
plugin/ignite-plugin/src/main/scala/org/finos/vuu/feature/ignite/schema/SchemaMapper.scala
Outdated
Show resolved
Hide resolved
- allows for cleaner flow of code
junaidzm13
force-pushed
the
1167-follow-up-small-refactor
branch
from
e80e66a to
a1fc13d
Compare
- IgniteEntitySchema's invalid index exception to check for and include all invalid indexes - SchemaMapper validation to not check for missing columns in fields map since there's a use-case (basket constituents) where it makes sense to not specify all internal columns in the fields map.
junaidzm13
force-pushed
the
1167-follow-up-small-refactor
branch
from
a1fc13d to
73593a9
Compare
naleeha
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.