1258 make opting out of ssl explicit for http/websocket options #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
junaidzm13
force-pushed
the
1258-make-opting0out-of-ssl-explicit
branch
from
dbf4590 to
337586f
Compare
junaidzm13
changed the title
- for now as a quick fix I've set ssl being enabled by default. So that user will always have to either call `withSslDisabled` to disable ssl or call `withSsl` to provide cert/key paths.
junaidzm13
force-pushed
the
1258-make-opting0out-of-ssl-explicit
branch
from
337586f to
1034eeb
Compare
|
Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make opting out of ssl explicit for http/websocket options
will always have to either call
withSslDisabledto disable ssl orcall
withSslto provide cert/key paths.