Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing peer dependency in ui packages #1322

Merged
merged 2 commits into from
May 1, 2024
Merged

add missing peer dependency in ui packages #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cccbc25
add missing peer dependency in ui packages
heswell May 1, 2024
67cc8ab
fix breaking calendar tests
heswell May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vuu-ui/packages/vuu-filters/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"uuid": "9.0.0"
},
"peerDependencies": {
"@internationalized/date": "^3.0.0",
"react": ">=17.0.2",
"react-dom": ">=17.0.2"
}
Expand Down
7 changes: 2 additions & 5 deletions vuu-ui/packages/vuu-filters/src/__tests__/__component__/Filterbar.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// TODO try and get TS path alias working to avoid relative paths like this
import { defaultPatternsByType, formatDate } from "@finos/vuu-utils";
import {
DefaultFilterBar,
FilterBarMultipleFilters,
Expand All @@ -9,6 +8,7 @@ import {
const FILTER_CONTAINER = ".vuuFilterBar-filters";
const ADD_BUTTON = ".vuuFilterBar-add";
const FILTER_CLAUSE = ".vuuFilterClause";
const VISIBLE_MONTH = ".saltCalendarCarousel-slide:not([aria-hidden])";

const findFilter = (className: string) =>
cy.get(FILTER_CONTAINER).find(className);
Expand Down Expand Up @@ -438,9 +438,6 @@ const getDate = (t: "start-today" | "start-tomorrow" | "end-today") => {

describe("WHEN a user applies a date filter", () => {
const DATE_COLUMN = "lastUpdated";
const todayDateFormatted = formatDate({ date: defaultPatternsByType.date })(
new Date()
);
const startOfToday = getDate("start-today").getTime();
const endOfToday = getDate("end-today").getTime();
const startOfTomorrow = getDate("start-tomorrow").getTime();
Expand Down Expand Up @@ -507,7 +504,7 @@ describe("WHEN a user applies a date filter", () => {
cy.get(ADD_BUTTON).realClick();
clickListItems(DATE_COLUMN, op);
cy.get(".vuuDatePopup .vuuIconButton").realClick();
cy.get(".saltCalendarDay-today:not(.saltCalendarDay-hidden)").realClick();
cy.get(`${VISIBLE_MONTH} .saltCalendarDay-today`).realClick();
cy.realPress("ArrowRight");
clickButton("Save");
waitUntilEditableLabelIsFocused();
Expand Down
1 change: 1 addition & 0 deletions vuu-ui/packages/vuu-ui-controls/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"@finos/vuu-utils": "0.0.26"
},
"peerDependencies": {
"@internationalized/date": "^3.0.0",
"clsx": "^2.0.0",
"react": ">=17.0.2",
"react-dom": ">=17.0.2"
Expand Down
1 change: 1 addition & 0 deletions vuu-ui/packages/vuu-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"@finos/vuu-protocol-types": "0.0.26"
},
"peerDependencies": {
"@internationalized/date": "^3.0.0",
"react": ">=17.0.2",
"react-dom": ">=17.0.2"
},
Expand Down
Loading