Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with VUU Server option for adding customised login validator is not setting #1397

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Bug with VUU Server option for adding customised login validator is not setting #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vuu/src/main/scala/org/finos/vuu/core/VuuServerOptions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ trait VuuThreadingOptions{

case class VuuSecurityOptionsImpl(authenticator: Authenticator, loginTokenValidator: LoginTokenValidator) extends VuuSecurityOptions{
override def withAuthenticator(authenticator: Authenticator): VuuSecurityOptions = this.copy(authenticator = authenticator)
override def withLoginValidator(tokenValidator: LoginTokenValidator): VuuSecurityOptions = this.copy(authenticator = authenticator)
override def withLoginValidator(tokenValidator: LoginTokenValidator): VuuSecurityOptions = this.copy(loginTokenValidator = tokenValidator)
}

private case class VuuWebSocketOptionsImpl(wsPort: Int,
Expand Down
20 changes: 20 additions & 0 deletions vuu/src/test/scala/org/finos/vuu/core/VuuServerOptionsTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package org.finos.vuu.core

import org.finos.vuu.net.LoggedInTokenValidator
import org.scalatest.featurespec.AnyFeatureSpec
import org.scalatest.matchers.should.Matchers


class VuuServerOptionsTest extends AnyFeatureSpec with Matchers {

Feature("VUU Server option for adding customised login validator should be supported"){

Scenario("Create 1 security option with LoggedInTokenValidator other than the default Validator, check the type of login validator"){

val option = VuuSecurityOptions.apply()
.withLoginValidator(new LoggedInTokenValidator)

option.loginTokenValidator shouldBe a [LoggedInTokenValidator]
}
}
}
Loading