Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web socket api test for get table meta #1431

Merged
merged 11 commits into from
Jul 17, 2024
Merged

Conversation

naleeha
Copy link
Contributor

@naleeha naleeha commented Jul 16, 2024

  • Introduced way to write web socket api test - working progress and will evolve as we write more scenarios
  • Introduced configuration for turning of heartbeat for debugging/testing
  • fixed error scenarios for getting table meta data

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit f6ded4c
🔍 Latest deploy log https://app.netlify.com/sites/papaya-valkyrie-395400/deploys/6696918b2d2f090008e027a1

@naleeha naleeha requested review from rumakt and heswell July 16, 2024 15:33
Copy link
Contributor

@heswell heswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me, but I'm ill qualified to judge scala code

@heswell heswell merged commit 57395d6 into finos:main Jul 17, 2024
12 checks passed
@naleeha naleeha deleted the table_metadata branch September 10, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants